Skip to content

fix triple npe#12918

Merged
EarthChen merged 1 commit intoapache:3.2from
icodening:issuse_12862
Aug 17, 2023
Merged

fix triple npe#12918
EarthChen merged 1 commit intoapache:3.2from
icodening:issuse_12862

Conversation

@icodening
Copy link
Contributor

@icodening icodening commented Aug 16, 2023 •
edited
Loading

What is the purpose of the change

fix triple npe
#12862

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #12918 (d741e8c) into 3.2 (972a081) will increase coverage by 2.43%.
Report is 5 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12918      +/-   ##
============================================
+ Coverage     67.00%   69.43%   +2.43%     
  Complexity        2        2              
============================================
  Files          1782     1648     -134     
  Lines         71829    68380    -3449     
  Branches      10260     9992     -268     
============================================
- Hits          48127    47479     -648     
+ Misses        19072    16318    -2754     
+ Partials       4630     4583      -47

see 169 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

EarthChen
EarthChen reviewed Aug 17, 2023
View reviewed changes
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleInvoker.java
if (methodDescriptor.isGeneric()) {
Object[] args = new Object[3];
args[0] = RpcUtils.getMethodName(invocation);
args[1] = Arrays.stream(RpcUtils.getParameterTypes(invocation)).map(Class::getName).collect(Collectors.toList());
Copy link
Member

@EarthChen EarthChen Aug 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this part be precomputed

EarthChen
EarthChen requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

EarthChen
EarthChen approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 90325f2 into apache:3.2 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EarthChen EarthChen EarthChen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@icodening @codecov-commenter @EarthChen